fix(app): fix styling of read-only deck configurator #14116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deck configurator is read only (during protocol/maintenance run), any loaded deck fixtures should show default cursor on hover, not show remove icon, and not be clickable
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14116 +/- ##
====================================================
Coverage 70.44% 70.44%
====================================================
Files 2483 2483
Lines 70328 70395 +67
Branches 8770 8810 +40
====================================================
+ Hits 49542 49590 +48
- Misses 18635 18651 +16
- Partials 2151 2154 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
brenthagen
approved these changes
Dec 6, 2023
components/src/hardware-sim/DeckConfigurator/StagingAreaConfigFixture.tsx
Outdated
Show resolved
Hide resolved
components/src/hardware-sim/DeckConfigurator/StagingAreaConfigFixture.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-1987
Overview
When deck configurator is read only (during protocol/maintenance run), any loaded deck fixtures
should show default cursor on hover, not show remove icon, and not be clickable
Test Plan
Screen.Recording.2023-12-06.at.2.25.10.PM.mov
Risk assessment
low